-
-
Notifications
You must be signed in to change notification settings - Fork 12
test: Mobile test runner #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
11b786a to
38b64ee
Compare
e619430 to
a89e7d0
Compare
4c4caf9 to
852e5fd
Compare
2e0714a to
4f6245b
Compare
4f6245b to
6a6af24
Compare
| TEST_PATHS=("res://test/suites/") | ||
| highlight "\nLooking for isolated test suites..." | ||
| TEST_PATHS+=($(find project/test/isolated -name "test_*.gd" -type f | sort)) | ||
| abort_on_error "Failed to find isolated test suites" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Misleading success hides critical command errors.
The abort_on_error call checks the exit code of the array assignment TEST_PATHS+=(...), not the find command itself. Array assignments succeed even when find returns no results, making this error check ineffective. If find fails (e.g., directory doesn't exist), the assignment still succeeds with an empty result, and the error goes undetected until the later check at line 204.
This PR:
#skip-changelog