Skip to content

Do not set the exception group marker when there is a suppressed exception #4056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 3 commits into from
Jan 17, 2025
+19 −10
Merged

Do not set the exception group marker when there is a suppressed exception #4056

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0917c6
Do set the exception group marker when there is a suppressed exception
adinauer Jan 16, 2025
d53ecc0
changelog
adinauer Jan 17, 2025
dc0abe0
comment out test assertions for is group flag
adinauer Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sentry/src/main/java/io/sentry/SentryExceptionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,9 @@ Deque<SentryException> extractExceptionQueueInternal(

Throwable[] suppressed = currentThrowable.getSuppressed();
if (suppressed != null && suppressed.length > 0) {
exceptionMechanism.setExceptionGroup(true);
// Disabled for now as it causes grouping in Sentry to sometimes use
// the suppressed exception as main exception.
// exceptionMechanism.setExceptionGroup(true);
for (Throwable suppressedThrowable : suppressed) {
extractExceptionQueueInternal(
suppressedThrowable, exceptionId, circularityDetector, exceptions);
Expand Down
Loading