Skip to content

Replace awaitility with CountDownLatch to try and fix the test on CI #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adinauer merged 5 commits into from
Jan 22, 2025
Merged

Replace awaitility with CountDownLatch to try and fix the test on CI #4084

adinauer merged 5 commits into from
Jan 22, 2025

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Jan 21, 2025 •
edited
Loading

#skip-changelog

📜 Description

Replace awaitility with CountDownLatch to try and fix the test on CI

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 462.35 ms 543.59 ms 81.24 ms
Size 1.65 MiB 2.31 MiB 677.55 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: fix/rate-limiter-test-close-cancels-timer-fix

Startup times

Revision Plain With Sentry Diff
04c8125 666.81 ms 736.85 ms 70.04 ms

App size

Revision Plain With Sentry Diff
04c8125 1.65 MiB 2.31 MiB 677.54 KiB

adinauer
adinauer commented Jan 21, 2025
View reviewed changes
@adinauer adinauer merged commit 926429a into main Jan 22, 2025
38 checks passed
@adinauer adinauer deleted the fix/rate-limiter-test-close-cancels-timer-fix branch January 22, 2025 07:59
lcian pushed a commit that referenced this pull request Jan 22, 2025
@adinauer @lcian
Replace awaitility with CountDownLatch to try and fix the test on CI (#…
ade8b09 
…4084)

* Replace awaitility with CountDownLatch to try and fix the test on CI

* Update sentry/src/test/java/io/sentry/transport/RateLimiterTest.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcian lcian lcian approved these changes

@romtsn romtsn Awaiting requested review from romtsn romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi markushi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adinauer @lcian