Skip to content

[dnm] testing: Remove buildscript block from root build.gradle #4432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[dnm] testing: Remove buildscript block from root build.gradle #4432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ed5ff3
Remove buildscript block from root build.gradle
runningcode May 22, 2025
62f5a32
add spring boot two to root
runningcode May 22, 2025
7a1685c
add commons compress
runningcode May 22, 2025
4eab774
move to buildscript classpath
runningcode May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,15 @@ plugins {
alias(libs.plugins.errorprone) apply false
alias(libs.plugins.gradle.versions) apply false
alias(libs.plugins.spring.dependency.management) apply false
id("com.android.library") version Config.AGP apply false
id("com.android.application") version Config.AGP apply false
// add classpath of sentry android gradle plugin
// id("io.sentry.android.gradle") version "5.6.0" apply false
}

buildscript {
repositories {
google()
}
dependencies {
classpath(Config.BuildPlugins.androidGradle)

// add classpath of sentry android gradle plugin
// classpath("io.sentry:sentry-android-gradle-plugin:{version}")

classpath(Config.BuildPlugins.commonsCompressOverride)
classpath(libs.commons.compress)
}
}

Expand Down
5 changes: 0 additions & 5 deletions buildSrc/src/main/java/Config.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ object Config {

val androidComposeCompilerVersion = "1.5.14"

object BuildPlugins {
val androidGradle = "com.android.tools.build:gradle:$AGP"
val commonsCompressOverride = "org.apache.commons:commons-compress:1.25.0"
}

object Android {
val abiFilters = listOf("x86", "armeabi-v7a", "x86_64", "arm64-v8a")

Expand Down
1 change: 1 addition & 0 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ androidx-navigation-runtime = { module = "androidx.navigation:navigation-runtime
androidx-navigation-compose = { module = "androidx.navigation:navigation-compose", version.ref = "androidxNavigation" }
coil-compose = { module = "io.coil-kt:coil-compose", version = "2.6.0" }
kotlin-test-junit = { module = "org.jetbrains.kotlin:kotlin-test-junit", version.ref = "kotlin" }
commons-compress = { module = "org.apache.commons:commons-compress", version = "1.25.0" }

# test libraries
androidx-test-core = { module = "androidx.test:core", version.ref = "androidxTestCore" }
Expand Down
1 change: 1 addition & 0 deletions settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ pluginManagement {
repositories {
mavenCentral()
gradlePluginPortal()
google()
}
}

Expand Down
Loading