Skip to content

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Oct 13, 2025

📜 Description

  • Set minimum screenshot size to 16 (minimum block size for encoding)
  • Check earlier if a root view has an associated window - if not, then we cannot take screenshots of it and should not even track it

💡 Motivation and Context

Closes #4548
Closes #4802

💚 How did you test it?

Manually using smartlook (which adds an invisible window on top), it's a bit tricky to unit test it

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

cursor[bot]

This comment was marked as outdated.

override fun onRootViewsChanged(root: View, added: Boolean) {
rootViewsLock.acquire().use {
if (added) {
if (root.phoneWindow == null) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markushi not sure if this is a problem for the CanvasStrategy - or can it actually still capture this cases?

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 385.50 ms 404.98 ms 19.48 ms
Size 1.58 MiB 2.11 MiB 539.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d205d0 352.15 ms 432.53 ms 80.38 ms
bdbe1f4 380.66 ms 464.44 ms 83.78 ms
9fbb112 359.71 ms 421.85 ms 62.14 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
3998a95 415.94 ms 478.54 ms 62.60 ms
14ff5ee 419.75 ms 495.73 ms 75.98 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
b750b96 408.98 ms 480.32 ms 71.34 ms
c8125f3 397.65 ms 485.14 ms 87.49 ms
b750b96 421.25 ms 444.09 ms 22.84 ms

App size

Revision Plain With Sentry Diff
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
bdbe1f4 1.58 MiB 2.11 MiB 538.88 KiB
9fbb112 1.58 MiB 2.11 MiB 539.18 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3998a95 1.58 MiB 2.10 MiB 532.96 KiB
14ff5ee 1.58 MiB 2.10 MiB 535.08 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
b750b96 1.58 MiB 2.10 MiB 533.20 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant