Skip to content

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Oct 14, 2025

📜 Description

  • Add new ctor overloads that accept a handler to deliver the callbacks of the integrations on
  • Additionally deduplicate SystemEventsIntegration and favour the user-added ones

💡 Motivation and Context

Part of getsentry/sentry-dotnet#3828
Closes #4700

💚 How did you test it?

Automated

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@romtsn
Copy link
Member Author

romtsn commented Oct 14, 2025

cc @jpnurmi @jamescrosswell

Copy link
Contributor

github-actions bot commented Oct 14, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8311e2f

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.26 ms 473.94 ms 82.68 ms
Size 1.58 MiB 2.11 MiB 539.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3d205d0 352.15 ms 432.53 ms 80.38 ms
bdbe1f4 380.66 ms 464.44 ms 83.78 ms
9fbb112 359.71 ms 421.85 ms 62.14 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
3998a95 415.94 ms 478.54 ms 62.60 ms
14ff5ee 419.75 ms 495.73 ms 75.98 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
b750b96 408.98 ms 480.32 ms 71.34 ms
c8125f3 397.65 ms 485.14 ms 87.49 ms
b750b96 421.25 ms 444.09 ms 22.84 ms

App size

Revision Plain With Sentry Diff
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
bdbe1f4 1.58 MiB 2.11 MiB 538.88 KiB
9fbb112 1.58 MiB 2.11 MiB 539.18 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3998a95 1.58 MiB 2.10 MiB 532.96 KiB
14ff5ee 1.58 MiB 2.10 MiB 535.08 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
b750b96 1.58 MiB 2.10 MiB 533.20 KiB

@jpnurmi
Copy link

jpnurmi commented Oct 14, 2025

Hi @romtsn, this is amazing - thanks so much!

I can confirm that both network and battery breadcrumbs are delivered in the main thread with this. 👍

https://github.com/getsentry/sentry-dotnet/blob/cdcde69631cba997b0261ef8de2f92ea3b46d6e7/src/Sentry/Platforms/Android/SentrySdk.cs#L161-L169

@romtsn
Copy link
Member Author

romtsn commented Oct 14, 2025

@jpnurmi great, thanks for trying out! I will wait for the maintainers' review and then merge and ship it soon

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network breadcrumbs are delivered in a background thread

3 participants