Skip to content

fix: Use sourcemaps.disable to disable debug ID upload instead of legacy upload #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix: Use sourcemaps.disable to disable debug ID upload instead of legacy upload #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/bundler-plugin-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,7 @@ export function sentryUnpluginFactory({
plugins.push(moduleMetadataInjectionPlugin(injectionCode));
}

if (options.sourcemaps?.disable) {
logger.debug("Source map upload was disabled. Will not upload sourcemaps.");
} else if (!options.release.name) {
if (!options.release.name) {
logger.warn(
"No release name provided. Will not create release. Please set the `release.name` option to identify your release."
);
Expand Down Expand Up @@ -355,7 +353,11 @@ export function sentryUnpluginFactory({

plugins.push(debugIdInjectionPlugin(logger));

if (!options.authToken) {
if (options.sourcemaps?.disable) {
logger.debug(
"Source map upload was disabled. Will not upload sourcemaps using debug ID process."
);
} else if (!options.authToken) {
logger.warn(
"No auth token provided. Will not upload source maps. Please set the `authToken` option. You can find information on how to generate a Sentry auth token here: https://docs.sentry.io/api/auth/"
);
Expand Down
Loading