Skip to content

fix: Use correct replacement matcher for bundleSizeOptimizations.excludeTracing #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 15, 2025
Merged

fix: Use correct replacement matcher for bundleSizeOptimizations.excludeTracing #644

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2907a6
Fix bundleSizeOptimizations.excludeTracing
jdelStrother Jan 6, 2025
832a10e
Merge branch 'main' into main
Jan 14, 2025
6a17663
Merge branch 'main' into main
Jan 15, 2025
2145afa
Merge branch 'main' into main
Jan 15, 2025
e5d5fb2
nudge ci?
Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bundler-plugin-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ export function sentryUnpluginFactory({
bundleSizeOptimizations.excludePerformanceMonitoring ||
bundleSizeOptimizations.excludeTracing
) {
replacementValues["__SENTRY_TRACE__"] = false;
replacementValues["__SENTRY_TRACING__"] = false;
}
if (bundleSizeOptimizations.excludeReplayCanvas) {
replacementValues["__RRWEB_EXCLUDE_CANVAS__"] = true;
Expand Down
2 changes: 1 addition & 1 deletion packages/bundler-plugin-core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ export type IncludeEntry = {

export interface SentrySDKBuildFlags extends Record<string, boolean | undefined> {
__SENTRY_DEBUG__?: boolean;
__SENTRY_TRACE__?: boolean;
__SENTRY_TRACING__?: boolean;
__RRWEB_EXCLUDE_CANVAS__?: boolean;
__RRWEB_EXCLUDE_IFRAME__?: boolean;
__RRWEB_EXCLUDE_SHADOW_DOM__?: boolean;
Expand Down
2 changes: 1 addition & 1 deletion packages/integration-tests/fixtures/bundle-size-optimizations/input/bundle2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
console.log({
debug: __SENTRY_DEBUG__ ? "a" : "b",
trace: __SENTRY_TRACE__ ? "a" : "b",
trace: __SENTRY_TRACING__ ? "a" : "b",
replayCanvas: __RRWEB_EXCLUDE_CANVAS__ ? "a" : "b",
replayIframe: __RRWEB_EXCLUDE_IFRAME__ ? "a" : "b",
replayShadowDom: __RRWEB_EXCLUDE_SHADOW_DOM__ ? "a" : "b",
Expand Down