fix(core): Avoid showing success message if upload was disabled or nothing was uploaded #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
approved these changes
Jul 11, 2025
3 tasks
Lms24
changed the title
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jul 27, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.5.0 | 3.6.1 | ## [v3.6.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#361) - fix(core): Observe and handle Sentry CLI sourcemap upload failures ([#763](getsentry/sentry-javascript-bundler-plugins#763)) ## [v3.6.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#360) - feat(core): Don't add `debugIdUploadPlugin` when sourcemaps option is disabled ([#753](getsentry/sentry-javascript-bundler-plugins#753)) - fix(core): Avoid showing success message if upload was disabled or nothing was uploaded ([#757](getsentry/sentry-javascript-bundler-plugins#757))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugged me and many users for a while: Because of a weird control flow in the debugID source maps upload plugin, we'd print the "Successfully uploaded source maps to Sentry" message if
This PR fixes both cases.
closes #670