fix(v2/core): Make moduleMetadata injection code ES5-compliant #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the v2
moduleMetadatacode snippet ES5-compliant by replacing theObject.assignmerge strategy of the module with a pure ES5 merge strategy: iterating over the object property of both objects to merge to the final object.Obviously, this increases the bundle size footpring but I think we need to prioritize correctness.
Reviewers can check 62321e2 which shows the new merge strategy prior to minification.
I also took the opportunity to minify the code and further isolate the
var-declared variables by wrapping the code in an IIFE. Adjusted to the tests to also usetoMatchSnapshot, since the inline snapshots would no longer be readable. Worth noting, we also have integration tests that actually check the behaviour, so I'm confident that the minified code still works correctly.I'll also open a similar PR to v4, since we decided to provide full ES5 compatibility again.
closes #768