Skip to content

feat(core): Add flag for disabling sourcemaps upload #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2025
Merged

feat(core): Add flag for disabling sourcemaps upload #785

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4e9742
add flag for disabling debugid upload
chargome Aug 7, 2025
76a0886
update api docs
chargome Aug 7, 2025
cd9c272
tests
chargome Aug 7, 2025
33fac40
Update packages/bundler-plugin-core/src/types.ts
chargome Aug 7, 2025
251f5a1
Merge branch 'main' into cg-webpack-disable-upload
chargome Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions packages/bundler-plugin-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,22 +126,24 @@ export function sentryUnpluginFactory({
if (!options.sourcemaps?.disable) {
plugins.push(debugIdInjectionPlugin(logger));

// This option is only strongly typed for the webpack plugin, where it is used. It has no effect on other plugins
const webpack_forceExitOnBuildComplete =
typeof options._experiments["forceExitOnBuildCompletion"] === "boolean"
? options._experiments["forceExitOnBuildCompletion"]
: undefined;

plugins.push(
debugIdUploadPlugin(
createDebugIdUploadFunction({
sentryBuildPluginManager,
}),
logger,
sentryBuildPluginManager.createDependencyOnBuildArtifacts,
webpack_forceExitOnBuildComplete
)
);
if (options.sourcemaps?.disable !== "disable-upload") {
// This option is only strongly typed for the webpack plugin, where it is used. It has no effect on other plugins
const webpack_forceExitOnBuildComplete =
typeof options._experiments["forceExitOnBuildCompletion"] === "boolean"
? options._experiments["forceExitOnBuildCompletion"]
: undefined;

plugins.push(
debugIdUploadPlugin(
createDebugIdUploadFunction({
sentryBuildPluginManager,
}),
logger,
sentryBuildPluginManager.createDependencyOnBuildArtifacts,
webpack_forceExitOnBuildComplete
)
);
}
}

if (options.reactComponentAnnotation) {
Expand Down
2 changes: 1 addition & 1 deletion packages/bundler-plugin-core/src/options-mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export type NormalizedOptions = {
disable: boolean;
sourcemaps:
| {
disable?: boolean;
disable?: boolean | "disable-upload";
assets?: string | string[];
ignore?: string | string[];
rewriteSources?: RewriteSourcesHook;
Expand Down
5 changes: 4 additions & 1 deletion packages/bundler-plugin-core/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,12 @@ export interface Options {
/**
* Disables all functionality related to sourcemaps.
*
* If set to `"disable-upload"`, the plugin will not upload sourcemaps to Sentry, but will inject debug IDs into the build artifacts.
* This is useful if you want to manually upload sourcemaps to Sentry at a later point in time.
*
* Defaults to `false`.
*/
disable?: boolean;
disable?: boolean | "disable-upload";

/**
* A glob or an array of globs that specifies the build artifacts that should be uploaded to Sentry.
Expand Down
Loading