Skip to content

fix: Strip query strings from asset paths #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2025
Merged

fix: Strip query strings from asset paths #806

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf484a
fix: Strip query strings from asset paths
timfish Oct 6, 2025
21aec56
PR review
timfish Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/bundler-plugin-core/src/debug-id-upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ export function createDebugIdUploadFunction({
sentryBuildPluginManager,
}: DebugIdUploadPluginOptions) {
return async (buildArtifactPaths: string[]) => {
await sentryBuildPluginManager.uploadSourcemaps(buildArtifactPaths);
// Webpack and perhaps other bundlers allow you to append query strings to
// filenames for cache busting purposes. We should strip these before upload.
const cleanedPaths = buildArtifactPaths.map((p) => p.split("?")[0] || p);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: we already have a stripQueryAndHashFromPath helper we can reuse here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah missed that!

await sentryBuildPluginManager.uploadSourcemaps(cleanedPaths);
};
}

Expand Down
1 change: 1 addition & 0 deletions packages/integration-tests/utils/create-cjs-bundles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ export function createCjsBundles(
output: {
path: path.join(outFolder, "webpack4"),
libraryTarget: "commonjs",
filename: "[name].js?[contenthash]",
},
target: "node", // needed for webpack 4 so we can access node api
plugins: [sentryWebpackPlugin(sentryUnpluginOptions)],
Expand Down
Loading