test: Fix failing integration tests on Windows #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
Lms24
requested review from
a team,
AbhiPrasad and
RulaKhaled
and removed request for
a team
AbhiPrasad
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So as you can see from this beautiful commit history, this PR fixes failing integration tests in our repo. I have no idea why they didn't fail earlier. Most likely because we have some Nx cache issue. As for the tests, it looks like we used the wrong logic for deriving
__dirnamefromimport.meta.urlin Windows. This PR fixes that.See nodejs/node#37845 (comment) for further details