fix: propagate the debug option to the cli #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Oct 10, 2025
Lms24
reviewed
Oct 10, 2025
| ] = `${bundlerPluginMetaContext.buildTool}-plugin/${__PACKAGE_VERSION__}`; | ||
|
|
||
| // Propagate debug flag to Sentry CLI via environment variable | ||
| if (options.debug) { |
There was a problem hiding this comment.
actually, let's only set this env var, if it isn't already set, wdyt? The main issue I wanna avoid is someone intentionally trying to silence the CLI output even if they set the plugin debug flag to true.
There was a problem hiding this comment.
Makes sense to me, I can document this as well in the docs so they understand the precedence is:
ENV_IF_EXIST > CONFIG
EDIT: Done!
logaretm
deleted the
awad/bundler-41-debug-likely-not-propagated-to-cli
branch
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Oct 20, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 4.4.0 | 4.5.0 | ## [v4.5.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#450) - docs: added info on debug flag value precedence ([#811](getsentry/sentry-javascript-bundler-plugins#811)) - feat: add debug statements after sourcemap uploads ([#812](getsentry/sentry-javascript-bundler-plugins#812)) - feat(core): Allow multi-project sourcemaps upload ([#813](getsentry/sentry-javascript-bundler-plugins#813)) - fix: propagate the debug option to the cli ([#810](getsentry/sentry-javascript-bundler-plugins#810))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds logic to ensure we are properly passing the debug flag to the Sentry CLI via an environment variable by setting it on the
process.envsimilar to other flags.closes #673