Skip to content

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 27, 2025

This PR migrates the native modules code of @sentry/profiling-node from the Sentry JavaScript monorepo.

  • The history for ./bindings/cpu_profiler.cc already exists in this repo
  • The other supporting code has been copied over
  • The Github build.yml workflow is mostly copied chunks with some modifications
  • This module is CJS only with only a main entry in the package.json
    • The native modules are all loaded via require so bundlers can analyse this
  • The tests are mostly copied over with the following changes:
    • Uses Vitest to run the tests
    • Tests against the actual tarball which ensures all the required binaries are included
    • We test all the supported Node versions on every platform and architecture GHA supports (x64 + arm64 where available)

@timfish timfish marked this pull request as ready for review January 27, 2025 16:00
@timfish timfish requested a review from AbhiPrasad January 27, 2025 16:00
@timfish timfish changed the title feat: Move native module from JavaScript repository feat: Move native module from JavaScript mono-repository Jan 27, 2025
@timfish timfish enabled auto-merge (squash) January 27, 2025 16:11
@timfish timfish merged commit 1c22cef into main Jan 27, 2025
46 checks passed
@AbhiPrasad AbhiPrasad deleted the feat/migrate branch January 27, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants