Skip to content

Commit 3100ead

Browse files
committed
fix(core): Apply breadcrumb log level function in packages where addBreadcrumb is called
Signed-off-by: Kaung Zin Hein <[email protected]>
1 parent 80efec1 commit 3100ead

File tree

7 files changed

+50
-7
lines changed

7 files changed

+50
-7
lines changed

packages/browser/src/integrations/breadcrumbs.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {
44
addHistoryInstrumentationHandler,
55
addXhrInstrumentationHandler,
66
} from '@sentry-internal/browser-utils';
7-
import { addBreadcrumb, defineIntegration, getClient } from '@sentry/core';
7+
import { addBreadcrumb, defineIntegration, getBreadcrumbLogLevel, getClient } from '@sentry/core';
88
import type {
99
Breadcrumb,
1010
Client,
@@ -247,11 +247,14 @@ function _getXhrBreadcrumbHandler(client: Client): (handlerData: HandlerDataXhr)
247247
endTimestamp,
248248
};
249249

250+
const level = getBreadcrumbLogLevel(status_code);
251+
250252
addBreadcrumb(
251253
{
252254
category: 'xhr',
253255
data,
254256
type: 'http',
257+
level,
255258
},
256259
hint,
257260
);
@@ -309,11 +312,14 @@ function _getFetchBreadcrumbHandler(client: Client): (handlerData: HandlerDataFe
309312
startTimestamp,
310313
endTimestamp,
311314
};
315+
const level = getBreadcrumbLogLevel(data.status_code);
316+
312317
addBreadcrumb(
313318
{
314319
category: 'fetch',
315320
data,
316321
type: 'http',
322+
level,
317323
},
318324
hint,
319325
);

packages/cloudflare/src/integrations/fetch.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1-
import { addBreadcrumb, defineIntegration, getClient, instrumentFetchRequest, isSentryRequestUrl } from '@sentry/core';
1+
import {
2+
addBreadcrumb,
3+
defineIntegration,
4+
getBreadcrumbLogLevel,
5+
getClient,
6+
instrumentFetchRequest,
7+
isSentryRequestUrl,
8+
} from '@sentry/core';
29
import type {
310
Client,
411
FetchBreadcrumbData,
@@ -144,11 +151,14 @@ function createBreadcrumb(handlerData: HandlerDataFetch): void {
144151
startTimestamp,
145152
endTimestamp,
146153
};
154+
const level = getBreadcrumbLogLevel(data.status_code);
155+
147156
addBreadcrumb(
148157
{
149158
category: 'fetch',
150159
data,
151160
type: 'http',
161+
level,
152162
},
153163
hint,
154164
);

packages/core/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ export { parseSampleRate } from './utils/parseSampleRate';
8484
export { applySdkMetadata } from './utils/sdkMetadata';
8585
export { getTraceData } from './utils/traceData';
8686
export { getTraceMetaTags } from './utils/meta';
87+
export { getBreadcrumbLogLevel } from './utils/breadcrumbsUtils';
8788
export { DEFAULT_ENVIRONMENT } from './constants';
8889
export { addBreadcrumb } from './breadcrumbs';
8990
export { functionToStringIntegration } from './integrations/functiontostring';

packages/deno/src/integrations/breadcrumbs.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { addBreadcrumb, defineIntegration, getClient } from '@sentry/core';
1+
import { addBreadcrumb, defineIntegration, getBreadcrumbLogLevel, getClient } from '@sentry/core';
22
import type {
33
Client,
44
Event as SentryEvent,
@@ -178,11 +178,14 @@ function _getFetchBreadcrumbHandler(client: Client): (handlerData: HandlerDataFe
178178
startTimestamp,
179179
endTimestamp,
180180
};
181+
const level = getBreadcrumbLogLevel(data.status_code);
182+
181183
addBreadcrumb(
182184
{
183185
category: 'fetch',
184186
data,
185187
type: 'http',
188+
level,
186189
},
187190
hint,
188191
);

packages/node/src/integrations/http.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { addOpenTelemetryInstrumentation } from '@sentry/opentelemetry';
66
import {
77
addBreadcrumb,
88
defineIntegration,
9+
getBreadcrumbLogLevel,
910
getCapturedScopesOnSpan,
1011
getCurrentScope,
1112
getIsolationScope,
@@ -229,14 +230,18 @@ function _addRequestBreadcrumb(
229230
}
230231

231232
const data = getBreadcrumbData(request);
233+
const statusCode = response.statusCode;
234+
const level = getBreadcrumbLogLevel(statusCode);
235+
232236
addBreadcrumb(
233237
{
234238
category: 'http',
235239
data: {
236-
status_code: response.statusCode,
240+
status_code: statusCode,
237241
...data,
238242
},
239243
type: 'http',
244+
level,
240245
},
241246
{
242247
event: 'response',

packages/node/src/integrations/node-fetch.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import type { UndiciRequest, UndiciResponse } from '@opentelemetry/instrumentation-undici';
22
import { UndiciInstrumentation } from '@opentelemetry/instrumentation-undici';
3-
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, addBreadcrumb, defineIntegration } from '@sentry/core';
3+
import {
4+
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
5+
addBreadcrumb,
6+
defineIntegration,
7+
getBreadcrumbLogLevel,
8+
} from '@sentry/core';
49
import { addOpenTelemetryInstrumentation } from '@sentry/opentelemetry';
510
import type { IntegrationFn, SanitizedRequestData } from '@sentry/types';
611
import { getSanitizedUrlString, parseUrl } from '@sentry/utils';
@@ -56,15 +61,18 @@ export const nativeNodeFetchIntegration = defineIntegration(_nativeNodeFetchInte
5661
/** Add a breadcrumb for outgoing requests. */
5762
function addRequestBreadcrumb(request: UndiciRequest, response: UndiciResponse): void {
5863
const data = getBreadcrumbData(request);
64+
const statusCode = response.statusCode;
65+
const level = getBreadcrumbLogLevel(statusCode);
5966

6067
addBreadcrumb(
6168
{
6269
category: 'http',
6370
data: {
64-
status_code: response.statusCode,
71+
status_code: statusCode,
6572
...data,
6673
},
6774
type: 'http',
75+
level,
6876
},
6977
{
7078
event: 'response',

packages/vercel-edge/src/integrations/wintercg-fetch.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
1-
import { addBreadcrumb, defineIntegration, getClient, instrumentFetchRequest, isSentryRequestUrl } from '@sentry/core';
1+
import {
2+
addBreadcrumb,
3+
defineIntegration,
4+
getBreadcrumbLogLevel,
5+
getClient,
6+
instrumentFetchRequest,
7+
isSentryRequestUrl,
8+
} from '@sentry/core';
29
import type {
310
Client,
411
FetchBreadcrumbData,
@@ -150,11 +157,14 @@ function createBreadcrumb(handlerData: HandlerDataFetch): void {
150157
startTimestamp,
151158
endTimestamp,
152159
};
160+
const level = getBreadcrumbLogLevel(data.status_code);
161+
153162
addBreadcrumb(
154163
{
155164
category: 'fetch',
156165
data,
157166
type: 'http',
167+
level,
158168
},
159169
hint,
160170
);

0 commit comments

Comments
 (0)