Skip to content

Commit b590352

Browse files
committed
set network transport to unknown in case it's not http / sse / stdio
1 parent 3e137ac commit b590352

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

packages/core/src/integrations/mcp-server/attributeExtraction.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,13 @@ export function getTransportTypes(transport: MCPTransport): { mcpTransport: stri
5454
return { mcpTransport: 'unknown', networkTransport: 'unknown' };
5555
}
5656

57-
const networkTransport = transportName.includes('stdio') ? 'pipe' : 'tcp';
57+
let networkTransport = 'unknown';
58+
59+
if (transportName.includes('stdio')) {
60+
networkTransport = 'pipe';
61+
} else if (transportName.includes('http') || transportName.includes('sse')) {
62+
networkTransport = 'tcp';
63+
}
5864

5965
return {
6066
mcpTransport: transportName,

packages/core/test/lib/integrations/mcp-server/transportInstrumentation.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,18 @@ describe('MCP Server Transport Instrumentation', () => {
559559
expect(result.mcpTransport).toBe('unknown');
560560
expect(result.networkTransport).toBe('unknown');
561561
});
562+
563+
it('returns unknown network transport for unrecognized transport types', () => {
564+
const transport = {
565+
constructor: { name: 'CustomTransport' },
566+
onmessage: () => {},
567+
send: async () => {},
568+
};
569+
const result = getTransportTypes(transport);
570+
571+
expect(result.mcpTransport).toBe('customtransport');
572+
expect(result.networkTransport).toBe('unknown');
573+
});
562574
});
563575

564576
describe('buildTransportAttributes sessionId handling', () => {

0 commit comments

Comments
 (0)