Skip to content

Conversation

@anonrig
Copy link
Contributor

@anonrig anonrig commented Jan 18, 2024

Hopefully, this might solve our Node 20 errors...

@anonrig anonrig requested review from a team, AbhiPrasad and Lms24 and removed request for a team January 18, 2024 16:47
@anonrig anonrig changed the title build: update lerna to v8.0.2 build: update lerna to v7.4.2 Jan 18, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm looks like Nx uses JS syntax we can't handle 🤔
https://github.com/getsentry/sentry-javascript/actions/runs/7575945958/job/20634368034?pr=10254#step:5:54

This sounds familiar, @mydea IIRC we encountered something like this before, right?

@anonrig
Copy link
Contributor Author

anonrig commented Jan 19, 2024

Hmm looks like Nx uses JS syntax we can't handle 🤔

@Lms24 I didn't understand how this passes before Node 14, but not in Node 14.

@Lms24
Copy link
Member

Lms24 commented Dec 12, 2024

I rebased this PR to check if things settled in the meantime. If not I'll close this in favour of looking into updating to lerna 8 in the future and as part of a general issue and PR cleanup initiative.

@Lms24
Copy link
Member

Lms24 commented Dec 12, 2024

Ok, the Node 14 tests are still failing. Maybe we can revisit this after v9 where we drop Node 14 and 16 support. For now though I'll close this. Thanks for giving this a try, Yagiz!

@Lms24 Lms24 closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants