fix(node): Remove deprecated routerPath warning of fastify request object

[Zen-cronic]

Fixes #12844

For the tests, would dev-packages/node-integration-tests/suites or dev-packages/e2e-tests/test-applications/node-fastify be a more appropriate location?

I also noticed that there's currently no test for fastify in node-integration.

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[mydea]

Hey, thanks for the PR! Could we do the same change as they did in OTEL:

const routeName = reqWithRouteInfo.routeOptions ? reqWithRouteInfo.routeOptions.url : reqWithRouteInfo.routerPath;

Otherwise, this stops working on older fastify versions, I guess, which we do not want!

[Zen-cronic]

Oh i see! So the routerPath is kept for backwards compatibility.

[Zen-cronic]

About the test, we can spyOn/mock the process.emitWarning() (which fastify uses), and assert that it's never invoked. But the test runner uses Axios, which throws its own error when faced with a 404. This happens before reaching the fastify code. So mocking would have no effect.

Although the deprecation warning is not logged (when manually tested with the fixed code), I'm stuck at including the case into the test suite. Currently, only the AxiosError is tested. Any thoughts?

[AbhiPrasad]

I'm stuck at including the case into the test suite. Currently, only the AxiosError is tested

We should probably move away from Axios in general, I think this limitation is fine because we know the implementation works in OTEL.

Let's just leave a comment on the test about the deprecation warning not being logged.

[AbhiPrasad]

After we add a comment to the test, and rebase this PR to latest, it's good to go to merge in my eyes.

Thanks for the PR @Zen-cronic (also nice to see some Canadian contributions 🇨🇦)

[Zen-cronic]

After we add a comment to the test, and rebase this PR to latest, it's good to go to merge in my eyes.

Thanks for the PR @Zen-cronic (also nice to see some Canadian contributions 🇨🇦)

Happy to help :)

Also I believe my rebase works correctly?

Edit: I think I messed up.

[AbhiPrasad]

assigning myself to help get this merged in!

[AbhiPrasad]

For future readers - we had to pin this at ~4.23.2 because 4.33+ only works with TS 5, which breaks the rest of our tests 😬

[Zen-cronic]

Thanks for helping out!

[andreiborza]

@AbhiPrasad can this be merged?

[AbhiPrasad]

yeah let me rebase and try to get this to the finish line

[mydea]

This is superseded by #15542 - thank you for the effort on this!