feat(node): Add socketIoIntegration to node
#13578
Conversation
|
|
|
|
||
| createRunner(__dirname, 'scenario.js') | ||
| .expect({ transaction: SERVER_TRANSACTION }) | ||
| .expect({ transaction: CLIENT_TRANSACTION }) |
There was a problem hiding this comment.
I'm not sure why the server socket and client socket are not part of the same transaction. In scenario.js, the server socket emits an event to the client, which triggers the client to send back to the server.
Update: the transactions are also not part of the same trace (different trace_id) - verified by debugging.
There was a problem hiding this comment.
I guess this is expected given the same behaviour in other integrations where consumer and producer are separate.
Zen-cronic
force-pushed
the
feat/socketioIntegration-node
branch
from
93e0e53 to
8d2e189
Compare
Add otel integration and e2e tests. Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
Signed-off-by: Kaung Zin Hein <[email protected]>
| onHook(span) { | ||
| addOriginToSpan(span, 'auto.socket.otel.consumer'); | ||
| }, | ||
| traceReserved: true, |
There was a problem hiding this comment.
We should expose options such as traceReserved, emitIgnoreEventList, and onIgnoreEventList for users to configure.
There was a problem hiding this comment.
I agree but for now this looks like a great start!
|
i'm not sure why but the test setup is flaky - failing in some node versions in the ci, and locally failing sometimes. |
|
Closing because of #13310 (comment) |
3 participants
Resolves #13310
yarn lint) & (yarn test).