Skip to content

fix(nextjs): Widen removal of 404 transactions #13628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix(nextjs): Widen removal of 404 transactions #13628

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a49c1a
fix(nextjs): Widen removal of 404 transactions
Sep 9, 2024
bbd3f1d
Add test
Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/nextjs/src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,13 @@ export function init(options: NodeOptions): NodeClient | undefined {
return null;
}

// Filter out /404 transactions for pages-router which seem to be created excessively
if (event.transaction === '/404') {
// Filter out /404 transactions which seem to be created excessively
if (
// Pages router
event.transaction === '/404' ||
// App router (could be "GET /404", "POST /404", ...)
event.transaction?.match(/^(GET|HEAD|POST|PUT|DELETE|CONNECT|OPTIONS|TRACE|PATCH) \/404$/)
) {
return null;
}

Expand Down
Loading