ref(profiling): reinitialize profilerId on explicit stop calls #13681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
approved these changes
Sep 13, 2024
|
|
||
| // There is no off method to disable this, so we need to ensure to add the listener only once. This adds overhead | ||
| // to the event processing, but it is minimal as we short circuit if there is no profilerId active and return early. | ||
| this._client.on('beforeSendEvent', this._onBeforeSendThreadContextAssignment.bind(this)); |
There was a problem hiding this comment.
on should return a function that deregisters a callback. We can use that to disable it.
There was a problem hiding this comment.
Ahh, I missed that! I'll keep the same implementation I think bc of simplicity, but let me remove that comment
There was a problem hiding this comment.
Removed it and left a comment for future optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the functionality of profiler start and stop calls to regenerate the profilerId