fix(core): Don't return trace data in getTraceData and getTraceMetaTags if SDK is disabled
#13760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
AbhiPrasad and
s1gr1d
and removed request for
a team
Lms24
changed the title
getTraceData and getTraceMetaTags if SDK is disabledgetTraceData and getTraceMetaTags if SDK is disabled
s1gr1d
approved these changes
Sep 24, 2024
Lms24
force-pushed
the
lms/fix-core-getTraceData-sdk-disabled
branch
from
f40a005 to
6453d88
Compare
AbhiPrasad
approved these changes
Sep 26, 2024
Lms24
force-pushed
the
lms/fix-core-getTraceData-sdk-disabled
branch
from
b51915c to
ca986f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a discussion with @s1gr1d: The
getTraceDataandgetTraceMetaTagsfunctions returned data, even if the SDK was disabled entirely (enabled: false). These APIs are publicly exposed and users probably call them without being aware of this limitation (as well as us in our meta framework SDKs). This PR ensures that we don't return data in case the SDK is disabled.Added more tests to ensure this is now properly covered, along with a test for behaviour with
tracesSampleRate: 0.