feat(nuxt): Add unstable_sentryBundlerPluginOptions to module options
#13811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
requested review from
Lms24 and
lforst
and removed request for
lforst
3 tasks
|
Why |
|
@darthf1 We use this in e.g. Next.js or SolidStart to add the possibility to modify the underlying plugin options. It's an escape hatch and the underlying options could change if we upgrade the version of the bundler plugins in the Nuxt SDK. |
s1gr1d
commented
Sep 26, 2024
| * | ||
| * Please note that this option is unstable and may change in a breaking way in any release. | ||
| */ | ||
| unstable_sentryBundlerPluginOptions?: SentryRollupPluginOptions & SentryVitePluginOptions; |
There was a problem hiding this comment.
I used Options from @sentry/bundler-plugin-core first (as this is the type the other plugins inherit from) but this gave me the following build error:
ERROR The keyword 'interface' is reserved (4:0) in /[folders...]/sentry-javascript/node_modules/@sentry/bundler-plugin-core/dist/types/index.d.ts
The Options are defined as interface, but Rollup defines interface as reserved name. I think this is related but I couldn't figure out how to fix that.
Lms24
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to pass other options from the bundler plugins (vite and rollup).
closes #13380