Skip to content

fix(replay): Stop global event handling for paused replays #13815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix(replay): Stop global event handling for paused replays #13815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d9181d
feat: stop global event handling for paused replays
chargome Sep 26, 2024
ba81db9
add test
chargome Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/replay-internal/src/coreHandlers/handleGlobalEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import { shouldSampleForBufferEvent } from './util/shouldSampleForBufferEvent';
export function handleGlobalEventListener(replay: ReplayContainer): (event: Event, hint: EventHint) => Event | null {
return Object.assign(
(event: Event, hint: EventHint) => {
// Do nothing if replay has been disabled
if (!replay.isEnabled()) {
// Do nothing if replay has been disabled or paused
if (!replay.isEnabled() || replay.isPaused()) {
return event;
}

Expand Down
19 changes: 19 additions & 0 deletions packages/replay-internal/test/integration/coreHandlers/handleGlobalEvent.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,4 +397,23 @@ describe('Integration | coreHandlers | handleGlobalEvent', () => {

expect(handleGlobalEventListener(replay)(errorEvent, {})).toEqual(errorEvent);
});

it('does not add replayId if replay is paused', async () => {
const transaction = Transaction();
const error = Error();

replay['_isPaused'] = true;

expect(handleGlobalEventListener(replay)(transaction, {})).toEqual(
expect.not.objectContaining({
// no tags at all here by default
tags: expect.anything(),
}),
);
expect(handleGlobalEventListener(replay)(error, {})).toEqual(
expect.objectContaining({
tags: expect.not.objectContaining({ replayId: expect.anything() }),
}),
);
});
});
Loading