Skip to content

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 27, 2024

Not sure if this breaks anything. Draft for now to run against e2e tests

We received a report in Discord about a build error for users building their Remix app for Shopify Hydrogen. This probably won't fix the entire hydrogen story but it might be enough.

I think pointing import towards the browser entry point should work as I believe the Remix server part is CJS but not fully sure tbh

@Lms24 Lms24 self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
227 3 224 12
View the top 2 failed tests by shortest run time
server-errors.test.ts Sends a loader error to Sentry
Stack Traces | 30s run time
server-errors.test.ts:4:1 Sends a loader error to Sentry
server-transactions.test.ts Sends parameterized transaction name to Sentry
Stack Traces | 30s run time
server-transactions.test.ts:8:1 Sends parameterized transaction name to Sentry
View the full list of 1 ❄️ flaky tests
errorboundary.test.ts captures an exception

Flake rate in main: 29.41% (Passed 12 times, Failed 5 times)

Stack Traces | 30s run time
errorboundary.test.ts:4:1 captures an exception

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@Lms24
Copy link
Member Author

Lms24 commented Sep 27, 2024

welp that doesn't work, closing for now

@Lms24 Lms24 closed this Sep 27, 2024
@Lms24 Lms24 deleted the lms/fix-remix-missing-exports-condition branch December 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant