-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(profiler): scope require to binding import call #13834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a regression test
42e2a5b
to
a92ae7e
Compare
I'm going to do some testing first to see if this is even true, opened it thinking we have tests for isCJS and it would fail or pass, but doesn't look like we do. |
size-limit report 📦
|
b80980e
to
2a49051
Compare
This breaks bundlers 😭 |
This reverts commit bdfb055.
@JonasBa is this still relevant or should we close this? |
Not relevant anymore. |
Dont override global require, as it causes issues with our esm/cjs runtime detection and instead scope it to binding import call
Fixes: #13662