Skip to content

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Oct 1, 2024

Ref #13737

  • Stuff to figure out:
    • Can we completely disable build-time instrumentation or will error monitoring stop working?
    • We need to propagate trace data to the frontend somehow.

Copy link

codecov bot commented Oct 1, 2024

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
235 7 228 6
View the top 3 failed tests by shortest run time
isomorphic/getServerSideProps.test.ts Should record performance for getServerSideProps
Stack Traces | 1.47s run time
getServerSideProps.test.ts:4:5 Should record performance for getServerSideProps
isomorphic/getInitialProps.test.ts should propagate serverside `getInitialProps` trace to client
Stack Traces | 1.53s run time
getInitialProps.test.ts:4:5 should propagate serverside `getInitialProps` trace to client
pages-ssr-errors.test.ts Will capture error for SSR rendering error with a connected trace (Functional Component)
Stack Traces | 30s run time
pages-ssr-errors.test.ts:22:5 Will capture error for SSR rendering error with a connected trace (Functional Component)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@lforst lforst closed this Oct 10, 2024
@lforst lforst deleted the lforst-pages-router-otel-only branch December 3, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant