Skip to content

feat(replay): Clear fallback buffer when switching buffers #13914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat(replay): Clear fallback buffer when switching buffers #13914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/replay-internal/src/eventBuffer/EventBufferProxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,9 @@ export class EventBufferProxy implements EventBuffer {
// Wait for original events to be re-added before resolving
try {
await Promise.all(addEventPromises);

// Can now clear fallback buffer as it's no longer necessary
this._fallback.clear();
} catch (error) {
DEBUG_BUILD && logger.exception(error, 'Failed to add events when switching buffers.');
}
Expand Down
Loading