Skip to content

feat(replay): Do not log "timeout while trying to read resp body" as exception #13965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat(replay): Do not log "timeout while trying to read resp body" as exception #13965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/replay-internal/src/coreHandlers/util/fetchUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,11 @@ async function _parseFetchResponseBody(response: Response): Promise<[string | un
const text = await _tryGetResponseText(res);
return [text];
} catch (error) {
if (error instanceof Error && error.message.indexOf('Timeout') > -1) {
DEBUG_BUILD && logger.warn('Parsing text body from response timed out');
return [undefined, 'BODY_PARSE_TIMEOUT'];
}

DEBUG_BUILD && logger.exception(error, 'Failed to get text body from response');
return [undefined, 'BODY_PARSE_ERROR'];
}
Expand Down Expand Up @@ -299,8 +304,6 @@ function _tryGetResponseText(response: Response): Promise<string | undefined> {
)
.finally(() => clearTimeout(timeout));
});

return _getResponseText(response);
Comment on lines -302 to -303
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unreachable code

}

async function _getResponseText(response: Response): Promise<string> {
Expand Down
1 change: 1 addition & 0 deletions packages/replay-internal/src/types/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export type NetworkMetaWarning =
| 'TEXT_TRUNCATED'
| 'URL_SKIPPED'
| 'BODY_PARSE_ERROR'
| 'BODY_PARSE_TIMEOUT'
| 'UNPARSEABLE_BODY_TYPE';

interface NetworkMeta {
Expand Down
2 changes: 1 addition & 1 deletion packages/replay-internal/test/unit/coreHandlers/util/fetchUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ describe('Unit | coreHandlers | util | fetchUtils', () => {
]);

expect(res).toEqual({
_meta: { warnings: ['BODY_PARSE_ERROR'] },
_meta: { warnings: ['BODY_PARSE_TIMEOUT'] },
headers: {},
size: undefined,
});
Expand Down
Loading