Skip to content

perf(node): Truncate breadcrumb messages created by console integration #14006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2024
Merged

perf(node): Truncate breadcrumb messages created by console integration #14006

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84816b4
perf(node): Truncate breadcrumb messages created by console integration
Oct 17, 2024
be9195c
Just truncate bro
Oct 18, 2024
6418d22
Add tests
Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/node/src/integrations/console.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as util from 'node:util';
import { addBreadcrumb, defineIntegration, getClient } from '@sentry/core';
import type { IntegrationFn } from '@sentry/types';
import { addConsoleInstrumentationHandler, severityLevelFromString } from '@sentry/utils';
import { addConsoleInstrumentationHandler, severityLevelFromString, truncate } from '@sentry/utils';

const INTEGRATION_NAME = 'Console';

Expand All @@ -18,7 +18,7 @@ const _consoleIntegration = (() => {
{
category: 'console',
level: severityLevelFromString(level),
message: util.format.apply(undefined, args),
message: truncate(util.format.apply(undefined, args), 2048), // 2KB
},
{
input: [...args],
Expand Down
Loading