fix(aws-serverless): Remove possible prototype pollution source #14110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
AbhiPrasad
changed the title
AbhiPrasad
requested review from
a team,
chargome and
stephanie-anderson
and removed request for
a team
chargome
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/getsentry/sentry-javascript/security/code-scanning/307
To fix the prototype pollution issue, we need to ensure that the
handlerNamedoes not include any special properties like__proto__,constructor, orprototype. We can achieve this by adding a check to filter out these properties before performing the assignment.handlerNamedoes not include__proto__,constructor, orprototype.handlerNameincludes any of these properties, log an error and return without making the assignment.Suggested fixes powered by Copilot Autofix. Review carefully before merging.