ci: Fix CodeQL workflow config #14117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
approved these changes
Oct 29, 2024
andreiborza
reviewed
Oct 29, 2024
| name: Analyze | ||
| runs-on: ubuntu-latest | ||
| # Skip for pushes from dependabot, which is not supported | ||
| if: github.event_name == 'pull_request' || github.actor != 'dependabot[bot]' |
There was a problem hiding this comment.
Wait, we skip pull requests? Should this be a &&?
There was a problem hiding this comment.
no, the job runs always if it is a pull request, or else if it is not from dependabot :D this is the condition to run, not to skip ;)
There was a problem hiding this comment.
Ah right. Forgot how the conditional jobs work and got confused by the comment. Thanks!
Lms24
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14109 and re-implements this differently.
Actually, the problem was dependabot merging to develop (so the fix would not have caught that anyhow), + this was incorrect syntax (oops) as we had ignore-branches and branches, which does not work.
Now, instead we just run this always but check if this is a push from dependabot, which hopefully works better.
See https://github.com/getsentry/sentry-javascript/actions/runs/11570166519