Skip to content

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Oct 30, 2024

Updated changelog without Nuxt pinia plugin changes as those were reverted in #14134

chargome and others added 5 commits October 29, 2024 15:52
Fixes
[https://github.com/getsentry/sentry-javascript/security/code-scanning/307](https://github.com/getsentry/sentry-javascript/security/code-scanning/307)

To fix the prototype pollution issue, we need to ensure that the
`handlerName` does not include any special properties like `__proto__`,
`constructor`, or `prototype`. We can achieve this by adding a check to
filter out these properties before performing the assignment.

1. Add a check to ensure `handlerName` does not include `__proto__`,
`constructor`, or `prototype`.
2. If `handlerName` includes any of these properties, log an error and
return without making the assignment.


_Suggested fixes powered by Copilot Autofix. Review carefully before
merging._

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
reverts #14047

This change needs to be re-evaluated as it currently adds bundle size
for all users.
meta(changelog): Merge changelog from master to develop
@s1gr1d s1gr1d requested a review from a team as a code owner October 30, 2024 09:37
@s1gr1d s1gr1d requested a review from mydea October 30, 2024 09:38
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB added added
@sentry/browser - with treeshaking flags 21.52 KB added added
@sentry/browser (incl. Tracing) 35.11 KB added added
@sentry/browser (incl. Tracing, Replay) 71.82 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.26 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 76.13 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.94 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.77 KB added added
@sentry/browser (incl. metrics) 26.98 KB added added
@sentry/browser (incl. Feedback) 39.87 KB added added
@sentry/browser (incl. sendFeedback) 27.37 KB added added
@sentry/browser (incl. FeedbackAsync) 32.17 KB added added
@sentry/react 25.48 KB added added
@sentry/react (incl. Tracing) 38.07 KB added added
@sentry/vue 26.87 KB added added
@sentry/vue (incl. Tracing) 36.99 KB added added
@sentry/svelte 22.86 KB added added
CDN Bundle 24.08 KB added added
CDN Bundle (incl. Tracing) 36.92 KB added added
CDN Bundle (incl. Tracing, Replay) 71.58 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.92 KB added added
CDN Bundle - uncompressed 70.62 KB added added
CDN Bundle (incl. Tracing) - uncompressed 109.61 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.13 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.35 KB added added
@sentry/nextjs (client) 38.15 KB added added
@sentry/sveltekit (client) 35.71 KB added added
@sentry/node 129.6 KB added added
@sentry/node - without tracing 94.3 KB added added
@sentry/aws-serverless 105.17 KB added added

@s1gr1d s1gr1d merged commit a566681 into master Oct 30, 2024
147 checks passed
@s1gr1d s1gr1d deleted the prepare-release/8.36.0 branch October 30, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants