Skip to content

Conversation

chargome
Copy link
Member

closes #14091

@chargome chargome self-assigned this Oct 30, 2024
@chargome chargome requested review from AbhiPrasad and Lms24 October 30, 2024 16:09
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we add some more context to the PR description about why we need this change.

What about webpack 4.x? Does this mean the react package won't work with that?

@chargome
Copy link
Member Author

@AbhiPrasad sorry I was shooting too fast on this one – just had a talk with Lukas and we might just add a note on docs since the issue (apparently) only affects custom webpack builds with terser. And CRA is still on ^5.64.4, so let's keep this as is for now.

@chargome chargome closed this Oct 30, 2024
@chargome chargome deleted the cg/add-webpack-optional-peer branch December 3, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terser plugin throws error during prod build for Sentry 8.x

2 participants