Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ Sentry.init({
integrations: [feedback],
});

feedback.attachTo('#custom-feedback-buttom');
feedback.attachTo('#custom-feedback-button');
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
<meta charset="utf-8" />
</head>
<body>
<button type="button" id="custom-feedback-buttom">Show feedback!</button>
<button type="button" id="custom-feedback-button">Show feedback!</button>
</body>
</html>
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ sentryTest('should capture feedback with custom button', async ({ getLocalTestUr
const url = await getLocalTestUrl({ testDir: __dirname });

await page.goto(url);
await page.locator('#custom-feedback-buttom').click();
await page.locator('#custom-feedback-button').click();
await page.waitForSelector(':visible:text-is("Report a Bug")');

expect(await page.locator(':visible:text-is("Report a Bug")').count()).toEqual(1);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ sentryTest(
'should catch onerror calls with non-string first argument gracefully',
async ({ getLocalTestPath, page, browserName }) => {
if (browserName === 'webkit') {
// This test fails on Webkit as erros thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
// This test fails on Webkit as errors thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
sentryTest.skip();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ sentryTest(
'should NOT catch an exception already caught [but rethrown] via Sentry.captureException',
async ({ getLocalTestPath, page, browserName }) => {
if (browserName === 'webkit') {
// This test fails on Webkit as erros thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
// This test fails on Webkit as errors thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
sentryTest.skip();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getFirstSentryEnvelopeRequest, runScriptInSandbox } from '../../../../.

sentryTest('should catch syntax errors', async ({ getLocalTestPath, page, browserName }) => {
if (browserName === 'webkit') {
// This test fails on Webkit as erros thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
// This test fails on Webkit as errors thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
sentryTest.skip();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getFirstSentryEnvelopeRequest, runScriptInSandbox } from '../../../../.

sentryTest('should catch thrown errors', async ({ getLocalTestPath, page, browserName }) => {
if (browserName === 'webkit') {
// This test fails on Webkit as erros thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
// This test fails on Webkit as errors thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
sentryTest.skip();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getFirstSentryEnvelopeRequest, runScriptInSandbox } from '../../../../.

sentryTest('should catch thrown objects', async ({ getLocalTestPath, page, browserName }) => {
if (browserName === 'webkit') {
// This test fails on Webkit as erros thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
// This test fails on Webkit as errors thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
sentryTest.skip();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getFirstSentryEnvelopeRequest, runScriptInSandbox } from '../../../../.

sentryTest('should catch thrown strings', async ({ getLocalTestPath, page, browserName }) => {
if (browserName === 'webkit') {
// This test fails on Webkit as erros thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
// This test fails on Webkit as errors thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
sentryTest.skip();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ sentryTest(
'should capture an error within a sync startSpan callback',
async ({ getLocalTestPath, page, browserName }) => {
if (browserName === 'webkit') {
// This test fails on Webkit as erros thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
// This test fails on Webkit as errors thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
sentryTest.skip();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ Sentry.init({

window.Replay._replay.timeouts = {
sessionIdlePause: 1000, // this is usually 5min, but we want to test this with shorter times
sessionIdleExpire: 900000, // defayult: 15min
sessionIdleExpire: 900000, // default: 15min
};
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ sentryTest(
const spans = [...res0.performanceSpans, ...res1.performanceSpans];
expect(breadcrumbs.filter(breadcrumb => breadcrumb.category === 'replay.throttled').length).toBe(1);
// replay.throttled breadcrumb does *not* use the throttledAddEvent as we
// alwants want that breadcrumb to be present in replay
// always want that breadcrumb to be present in replay
expect(breadcrumbs.length + spans.length).toBe(THROTTLE_LIMIT + 1);
},
);
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ sentryTest(
'should put the pageload transaction name onto an error event caught during pageload',
async ({ getLocalTestPath, page, browserName }) => {
if (browserName === 'webkit') {
// This test fails on Webkit as erros thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
// This test fails on Webkit as errors thrown from `runScriptInSandbox` are Script Errors and skipped by Sentry
sentryTest.skip();
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
const blockUI = e => {
const startTime = Date.now();

function getElasped() {
function getElapsed() {
const time = Date.now();
return time - startTime;
}

while (getElasped() < 70) {
while (getElapsed() < 70) {
//
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
(() => {
const startTime = Date.now();

function getElasped() {
function getElapsed() {
const time = Date.now();
return time - startTime;
}

while (getElasped() < 101) {
while (getElapsed() < 101) {
//
}
})();
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
(() => {
const startTime = Date.now();

function getElasped() {
function getElapsed() {
const time = Date.now();
return time - startTime;
}

while (getElasped() < 101) {
while (getElapsed() < 101) {
//
}
})();
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
(() => {
const startTime = Date.now();

function getElasped() {
function getElapsed() {
const time = Date.now();
return time - startTime;
}

while (getElasped() < 101) {
while (getElapsed() < 101) {
//
}
})();
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
(() => {
const startTime = Date.now();

function getElasped() {
function getElapsed() {
const time = Date.now();
return time - startTime;
}

while (getElasped() < 105) {
while (getElapsed() < 105) {
//
}
})();
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
(() => {
const startTime = Date.now();

function getElasped() {
function getElapsed() {
const time = Date.now();
return time - startTime;
}

while (getElasped() < 105) {
while (getElapsed() < 105) {
//
}
})();
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ sentryTest('should add resource spans to pageload transaction', async ({ getLoca
const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
const resourceSpans = eventData.spans?.filter(({ op }) => op?.startsWith('resource'));

// Webkit 16.0 (which is linked to Playwright 1.27.1) consistently creates 2 consectutive spans for `css`,
// Webkit 16.0 (which is linked to Playwright 1.27.1) consistently creates 2 consecutive spans for `css`,
// so we need to check for 3 or 4 spans.
if (browser.browserType().name() === 'webkit') {
expect(resourceSpans?.length).toBeGreaterThanOrEqual(3);
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/browser-integration-tests/utils/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ export function shouldSkipMetricsTest(): boolean {

/**
* Waits until a number of requests matching urlRgx at the given URL arrive.
* If the timout option is configured, this function will abort waiting, even if it hasn't reveived the configured
* amount of requests, and returns all the events recieved up to that point in time.
* If the timeout option is configured, this function will abort waiting, even if it hasn't received the configured
* amount of requests, and returns all the events received up to that point in time.
*/
async function getMultipleRequests<T>(
page: Page,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const DEFAULT_REPLAY_EVENT = {
* This is useful for testing multi-segment replays to not repeat most of the properties that don't change
* throughout the replay segments.
*
* Note: The benfit of this approach over expect.objectContaining is that,
* Note: The benefit of this approach over expect.objectContaining is that,
* we'll catch if properties we expect to stay the same actually change.
*
* @param customExpectedReplayEvent overwrite the default values with custom values (e.g. segment_id)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import Layout from '../layouts/Layout.astro';
<ul role="list" style="display: flex; flex-direction: column;">
<a href="/ssr-error">SSR Error</a>
<a href="/endpoint-error">Endpoint Error</a>
<a href="/client-error">Cliennt Error</a>
<a href="/client-error">Client Error</a>
<a href="/test-ssr">SSR page</a>
<a href="/test-static" title="static page">Static Page</a>
</ul>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { expect, test } from '@playwright/test';
import { waitForError, waitForTransaction } from '@sentry-internal/test-utils';

test('Should emit a span for a generateMetadata() function invokation', async ({ page }) => {
test('Should emit a span for a generateMetadata() function invocation', async ({ page }) => {
const testTitle = 'should-emit-span';

const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
Expand Down Expand Up @@ -29,7 +29,7 @@ test('Should emit a span for a generateMetadata() function invokation', async ({
expect(pageTitle).toBe(testTitle);
});

test('Should send a transaction and an error event for a faulty generateMetadata() function invokation', async ({
test('Should send a transaction and an error event for a faulty generateMetadata() function invocation', async ({
page,
}) => {
const testTitle = 'should-emit-error';
Expand Down Expand Up @@ -59,7 +59,7 @@ test('Should send a transaction and an error event for a faulty generateMetadata
expect(transactionEvent.tags?.['my-global-scope-isolated-tag']).not.toBeDefined();
});

test('Should send a transaction event for a generateViewport() function invokation', async ({ page }) => {
test('Should send a transaction event for a generateViewport() function invocation', async ({ page }) => {
const testTitle = 'floob';

const transactionPromise = waitForTransaction('nextjs-14', async transactionEvent => {
Expand All @@ -83,7 +83,7 @@ test('Should send a transaction event for a generateViewport() function invokati
);
});

test('Should send a transaction and an error event for a faulty generateViewport() function invokation', async ({
test('Should send a transaction and an error event for a faulty generateViewport() function invocation', async ({
page,
}) => {
const testTitle = 'blargh';
Expand All @@ -109,7 +109,7 @@ test('Should send a transaction and an error event for a faulty generateViewport
expect(errorEvent.transaction).toBe('Page.generateViewport (/generation-functions)');
});

test('Should send a transaction event with correct status for a generateMetadata() function invokation with redirect()', async ({
test('Should send a transaction event with correct status for a generateMetadata() function invocation with redirect()', async ({
page,
}) => {
const testTitle = 'redirect-foobar';
Expand All @@ -126,7 +126,7 @@ test('Should send a transaction event with correct status for a generateMetadata
expect((await transactionPromise).contexts?.trace?.status).toBe('ok');
});

test('Should send a transaction event with correct status for a generateMetadata() function invokation with notfound()', async ({
test('Should send a transaction event with correct status for a generateMetadata() function invocation with notfound()', async ({
page,
}) => {
const testTitle = 'notfound-foobar';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Sentry.init({
debug: !!process.env.DEBUG,
tunnel: `http://localhost:3031/`, // proxy server
skipOpenTelemetrySetup: true,
// By defining _any_ sample rate, tracing intergations will be added by default
// By defining _any_ sample rate, tracing integrations will be added by default
tracesSampleRate: 0,
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ test('Sends correct error event', async ({ baseURL }) => {
url: 'http://localhost:3030/test-exception/123',
});

// This is unparametrized here because we do not have the express instrumentation
// This is unparameterized here because we do not have the express instrumentation
expect(errorEvent.transaction).toEqual('GET /test-exception/123');

expect(errorEvent.contexts?.trace).toEqual({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ test('Waits for sse streaming when sse has been explicitly aborted', async ({ pa
expect(resolveDuration).toBe(0);
expect(resolveBodyDuration).toBe(0);

// validate abort eror was thrown by inspecting console
// validate abort error was thrown by inspecting console
const consoleBreadcrumb = rootSpan.breadcrumbs?.find(breadcrumb => breadcrumb.category === 'console');
expect(consoleBreadcrumb?.message).toBe('Could not fetch sse AbortError: BodyStreamBuffer was aborted');
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Sentry.init({
tracesSampler: samplingContext => {
// The name we get here is inferred at span creation time
// At this point, we sadly do not have a http.route attribute yet,
// so we infer the name from the unparametrized route instead
// so we infer the name from the unparameterized route instead
return (
samplingContext.name === 'GET /test/123' &&
samplingContext.attributes['sentry.op'] === 'http.server' &&
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/rollup-utils/plugins/extractPolyfillsPlugin.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const POLYFILL_NAMES = new Set([
]);

/**
* Create a plugin which will replace function definitions of any of the above funcions with an `import` or `require`
* Create a plugin which will replace function definitions of any of the above functions with an `import` or `require`
* statement pulling them in from a central source. Mimics tsc's `importHelpers` option.
*/
export function makeExtractPolyfillsPlugin() {
Expand All @@ -40,7 +40,7 @@ export function makeExtractPolyfillsPlugin() {
return null;
}

// The index.js file of the tuils package will include identifiers named after polyfills so we would inject the
// The index.js file of the utils package will include identifiers named after polyfills so we would inject the
// polyfills, however that would override the exports so we should just skip that file.
const isUtilsPackage = process.cwd().endsWith(`packages${path.sep}utils`);
if (isUtilsPackage && sourceFile === 'index.js') {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/size-limit-gh-action/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ async function run() {
const sizeLimitComment = await fetchPreviousComment(octokit, repo, pr);

if (sizeLimitComment) {
core.debug('Found existing size limit comment, udpating it instead of creating a new one...');
core.debug('Found existing size limit comment, updating it instead of creating a new one...');
}

const shouldComment =
Expand Down
4 changes: 2 additions & 2 deletions docs/creating-a-new-sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Some of the following concepts may be relevant to your SDK:
- **Redirects**: If possible, we want to skip redirects. This means that if a user navigates to `/`, and this redirects
the user internally to `/dashboard`, we only want to capture a single `/` navigation/pageload.
- **Route Params**: Routes should be parametrized, which means that instead of `/users/123` we want to capture
`/users/:id` or simmilar.
`/users/:id` or similar.
- **Query Params**: Query params should generally be removed from the route.

#### Component Tracking
Expand Down Expand Up @@ -88,7 +88,7 @@ own instrumentation to capture `http.server` spans.
Some of the following concepts may be relevant to your SDK:

- **Route Params**: Routes should be parametrized, which means that instead of `/users/123` we want to capture
`/users/:id` or simmilar.
`/users/:id` or similar.
- **Query Params**: Query params should generally be removed from the route.

#### Middleware Tracking
Expand Down
4 changes: 2 additions & 2 deletions docs/migration/feedback.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# End of Feedback Beta

With the release of 8.0.0, Sentry Feedback is now out of Beta. This means that the usual stabilty guarantees apply.
With the release of 8.0.0, Sentry Feedback is now out of Beta. This means that the usual stability guarantees apply.

Feedback 8.0.0 requires server version 24.4.2 and above.

Expand Down Expand Up @@ -89,7 +89,7 @@ function attachTo(button: HTMLElement) {
onFormClose: () => {
widget.close();
},
onFormSubmited: () => {
onFormSubmitted: () => {
widget.removeFromDom();
}
});
Expand Down
2 changes: 1 addition & 1 deletion docs/v8-node.md
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ const { SentrySpanProcessor, SentryPropagator, SentryContextManager, SentrySampl
// We need a custom span processor
provider.addSpanProcessor(new SentrySpanProcessor());
// We need a custom propagator and context manager
provier.register({
provider.register({
propagator: new SentryPropagator(),
contextManager: new SentryContextManager(),
});
Expand Down
Loading
Loading