feat(browser): Add skipBrowserExtensionCheck escape hatch option
#14147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
requested review from
a team,
stephanie-anderson,
AbhiPrasad and
s1gr1d
and removed request for
a team and
stephanie-anderson
s1gr1d
approved these changes
Oct 31, 2024
6 tasks
3 tasks
Lms24
added a commit
to getsentry/sentry-docs
that referenced
this pull request
Nov 7, 2024
adds documentation for a new SDK option introduced in getsentry/sentry-javascript#14147 --------- Co-authored-by: Alex Krawiec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v8, we added a check to stop initing the SDK via
Sentry.initif we detect it's being called in a browser extension. We had to adjust and add special conditions to this check multiple times because it triggered falsely in various environments we weren't aware of before (e.g. #12668). We received another issue where such a false positive was reported (#14133), so I'm thinking it's probably better to provide a general escape hatch for this check than to further bloat the bundle size by introducing more special cases in the extension check.This way, we'd initially still block
Sentry.initand make users think twice how to proceed. However, we don't have to adapt the check every time a false positive gets reported.(note for v9: Maybe we should rethink the check. I'm not happy with the bundle size hit this produces)