chore(astro): Bump astro dev dep to ^4.16.8 #14153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
Lms24 and
chargome
and removed request for
a team
Lms24
reviewed
Oct 31, 2024
| }, | ||
| "devDependencies": { | ||
| "astro": "^3.5.0", | ||
| "astro": "^4.16.8", |
There was a problem hiding this comment.
We still support Astro 3.0.0 and upwards (https://docs.sentry.io/platforms/javascript/guides/astro/#prerequisites). I guess the build is failing because some types changed in v4?
There was a problem hiding this comment.
I updated this to reflect v4.
I'd rather the package stays up-to-date with the latest version, and we use e2e tests to test against older versions when needed. What do you think?
AbhiPrasad
force-pushed
the
abhi-bump-astro-dev-dep
branch
from
91999c5 to
f62a368
Compare
|
Will revisit this later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/getsentry/sentry-javascript/security/dependabot/427 and https://github.com/getsentry/sentry-javascript/security/dependabot/425