Skip to content

ref(browser): Ensure start time of interaction root and child span is aligned #14188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024
Merged

ref(browser): Ensure start time of interaction root and child span is aligned #14188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aee64ff
ref(browser): Reduce bundle size for starting interaction child spans
Lms24 Nov 5, 2024
b650306
actually reduce lol
Lms24 Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/browser-utils/src/metrics/browserMetrics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ export function startTrackingLongAnimationFrames(): void {
*/
export function startTrackingInteractions(): void {
addPerformanceInstrumentationHandler('event', ({ entries }) => {
if (!getActiveSpan()) {
const parent = getActiveSpan();
if (!parent) {
return;
}
for (const entry of entries) {
Expand All @@ -214,10 +215,7 @@ export function startTrackingInteractions(): void {
spanOptions.attributes['ui.component_name'] = componentName;
}

const span = startInactiveSpan(spanOptions);
if (span) {
span.end(startTime + duration);
}
startAndEndSpan(parent, startTime, startTime + duration, spanOptions);
}
}
});
Expand Down
Loading