Skip to content

ref(profiling) Fix electron crash #14216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 13, 2024
Merged

ref(profiling) Fix electron crash #14216

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c82add5
ref(profiling) Fix electron crash
JonasBa Nov 8, 2024
baef45a
test(profiling) add electron e2e test
JonasBa Nov 11, 2024
d41cdb1
fixup! test(profiling) add electron e2e test
JonasBa Nov 11, 2024
9a4428c
remove yarn lockfile
JonasBa Nov 11, 2024
41f3b52
test: Install dependencies in e2e test
JonasBa Nov 11, 2024
4f136f5
try force install
JonasBa Nov 11, 2024
5ddb1b6
try pnpm
JonasBa Nov 12, 2024
7b3b666
point to binary directly
JonasBa Nov 12, 2024
77db181
install e2e deps
JonasBa Nov 12, 2024
4072ec0
Merge branch 'develop' into jb/profiling/electron-binaries
JonasBa Nov 12, 2024
fac3d34
fix correct path
JonasBa Nov 12, 2024
ebc5216
bump runner to see if it comes w newer deps
JonasBa Nov 13, 2024
ed37d35
test xvfb
JonasBa Nov 13, 2024
f2d27b0
remove obsolete package
JonasBa Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/profiling-node/bindings/cpu_profiler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,8 @@ void SentryProfile::Start(Profiler *profiler) {

// Initialize the CPU Profiler
profiler->cpu_profiler->StartProfiling(
profile_title,
{v8::CpuProfilingMode::kCallerLineNumbers,
v8::CpuProfilingOptions::kNoSampleLimit, kSamplingInterval});
profile_title, v8::CpuProfilingMode::kCallerLineNumbers, true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear why using the options signature causes this to sigabrt, but this will do too.

v8::CpuProfilingOptions::kNoSampleLimit);

// listen for memory sample ticks
profiler->measurements_ticker.add_cpu_listener(id, cpu_sampler_cb);
Expand Down Expand Up @@ -1169,6 +1168,7 @@ napi_value Init(napi_env env, napi_value exports) {
}

Profiler *profiler = new Profiler(env, isolate);
profiler->cpu_profiler->SetSamplingInterval(kSamplingInterval);

if (napi_set_instance_data(env, profiler, FreeAddonData, NULL) != napi_ok) {
napi_throw_error(env, nullptr, "Failed to set instance data for profiler.");
Expand Down
Loading