fix(nuxt): Fix dynamic import rollup plugin to work with latest nitro #14243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With nitro 2.10.X the way we imported the server config file and dynamically imported the nitro runtime broke. Instead of landing in the server output entry file, the sdk init and dynamic import landed in the nitro runtime itself.
Based on nitrojs/nitro@8b4a408#diff-e58102d2230f95ddeef2662957b48d847a6e891e354cfd0ae6e2e03ce848d1a2R142 we managed to get back to the original solution by using the
\0rawprefix for the entry file.Note for internal: This does not play well when using symlinks (like
yarn link) to link the sdk into a project. Haven't tested how yalc behaves, but tarballs work.