Skip to content

Conversation

chargome
Copy link
Member

closes #14249

@chargome chargome self-assigned this Nov 13, 2024
@chargome chargome changed the title debs(nextjs): Bump @rollup/plugin-commonjs deps(nextjs): Bump @rollup/plugin-commonjs Nov 13, 2024
@chargome chargome requested a review from lforst November 13, 2024 08:48
"@opentelemetry/api": "^1.9.0",
"@opentelemetry/instrumentation-http": "0.53.0",
"@opentelemetry/semantic-conventions": "^1.27.0",
"@rollup/plugin-commonjs": "26.0.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to clarify, are there no breaking changes here that affect us (e.g. node version support etc)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find anything, theres no changelog etc. so I relied on our own tests here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stuff is thoroughly tested.

Copy link
Member Author

@chargome chargome Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, there is actually one: https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md

just wasn't in the package itself

@chargome chargome merged commit 9e37c31 into develop Nov 13, 2024
151 checks passed
@chargome chargome deleted the cg/bump-rollup-plugin branch November 13, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An error occurred when security checking with Snyk in Github Actions using Nextjs

3 participants