Skip to content

fix(nextjs): Update check for not found navigation error #14378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix(nextjs): Update check for not found navigation error #14378

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac05aa7
update check for not found navigation error
chargome Nov 20, 2024
959652e
simplify code
chargome Nov 20, 2024
3fb31ce
Merge branch 'develop' into cg/fix-next-not-found-error
chargome Nov 21, 2024
6f2d364
mark turbo test as optional
chargome Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/nextjs/src/common/nextNavigationErrorUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@ import { isError } from '@sentry/utils';
* https://beta.nextjs.org/docs/api-reference/notfound#notfound
*/
export function isNotFoundNavigationError(subject: unknown): boolean {
return isError(subject) && (subject as Error & { digest?: unknown }).digest === 'NEXT_NOT_FOUND';
return (
isError(subject) &&
((subject as Error & { digest?: unknown }).digest === 'NEXT_NOT_FOUND' ||
// this was introduced in 15.0.4-canary.18: https://github.com/vercel/next.js/pull/72774
(subject as Error & { digest?: unknown }).digest === 'NEXT_HTTP_ERROR_FALLBACK;404')
);
}

/**
Expand Down
Loading