Skip to content

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Nov 22, 2024

No description provided.

billyvg and others added 5 commits November 21, 2024 14:54
Fixes an issue with long form titles causing the width of the dialog to
expand. Instead, apply the css var `--form-width` to the dialog contents
so that the title wraps.

After:
<img width="323" alt="image"
src="https://github.com/user-attachments/assets/b2982b72-e9df-4459-8241-4b47f2fdd4fe">

 
<img width="558" alt="image"
src="https://github.com/user-attachments/assets/cd4a2285-7088-4bc1-b628-9672861a71f2">

Single line:
<img width="344" alt="image"
src="https://github.com/user-attachments/assets/1661ca0d-8cea-435c-86a8-cc56913d0483">


Closes #14351
This makes a change so that when the event buffer is full, we will clear
it and wait for the next checkout instead of erroring and stopping the
replay buffering. This does mean that it's possible an exception occurs
in-between the filled buffer and the next checkout, where we will have
an empty replay
Optional tests should not block releases.

There are two groups of optional tests:
1. Canary type tests
2. Tests that send data to sentry

IMHO both of these can be skipped on release branches, as failure in
either of them should not affect the release. They will (for now) still
run on develop, we can revisit this if we want.
@lforst lforst changed the base branch from develop to master November 22, 2024 08:25
@lforst lforst requested review from a team as code owners November 22, 2024 08:25
@lforst lforst requested review from andreiborza and mydea November 22, 2024 08:25
@lforst lforst merged commit 87a90a3 into master Nov 22, 2024
35 checks passed
@lforst lforst deleted the prepare-release/8.40.0 branch November 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants