Skip to content

test(nextjs): Fix turbopack test #14455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged

test(nextjs): Fix turbopack test #14455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67b6035
shameful magic
chargome Nov 25, 2024
109c3b2
add comment
chargome Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dev-packages/e2e-tests/test-applications/nextjs-turbo/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,8 @@
@sentry:registry=http://127.0.0.1:4873
@sentry-internal:registry=http://127.0.0.1:4873

# todo: check if this is still needed in upcoming versions
# Hoist all dependencies to the root level due to issues with import-in-the-middle and require-in-the-middle
# Just adding these as dependencies removed the warnings, but didn't fix the issue
shamefully-hoist=true
Copy link
Member

@mydea mydea Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xD lol

Copy link
Member

@andreiborza andreiborza Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@andreiborza andreiborza Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: please add a comment so we know why we added this and that we should reevaluate it from time to time.

strict-peer-dependencies=false
Loading