Skip to content

Conversation

andreiborza
Copy link
Member

Noticed that our e2e tests are not actually using nitro 2.10 despite being on the latest nuxt version: https://github.com/getsentry/sentry-javascript/actions/runs/12028119465/job/33531969920#step:13:196

This fixes it.

@andreiborza andreiborza force-pushed the ab/e2e-nuxt-nitro-2.10-fix branch from 4fbaa01 to f12823a Compare November 26, 2024 12:27
@andreiborza andreiborza changed the title chore(nuxt): Upgrade nuxt version in e2e test to ensure we run with nitro 2.10 chore(nuxt): Remove nft override to ensure we are testing with latest nitro Nov 26, 2024
@andreiborza andreiborza force-pushed the ab/e2e-nuxt-nitro-2.10-fix branch from f12823a to c7ec7dc Compare November 26, 2024 12:27
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
Please also change the nuxt version "nuxt": "^3.13.1" to ^3.14.0 to make sure the dependencies are correctly added. As 3.14 adds a min. required dependency for nitro 2.10 (which includes the correct version for nft)

@andreiborza andreiborza merged commit 1d32374 into develop Nov 26, 2024
122 of 123 checks passed
@andreiborza andreiborza deleted the ab/e2e-nuxt-nitro-2.10-fix branch November 26, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants