Skip to content

fix(profiling): Make prune script compatible with node 22 #14491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2024
Merged

fix(profiling): Make prune script compatible with node 22 #14491

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c3c24a
add node 22 to prune script
chargome Nov 26, 2024
8af609c
Merge branch 'develop' into cg/profiling-update-prune-script
chargome Nov 28, 2024
9906e67
Merge branch 'develop' into cg/profiling-update-prune-script
chargome Dec 2, 2024
9f743a1
update log message
chargome Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/profiling-node/scripts/prune-profiler-binaries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ const NODE_TO_ABI = {
16: '93',
18: '108',
20: '115',
22: '127',
};

if (NODE) {
Expand All @@ -73,9 +74,13 @@ if (NODE) {
NODE = NODE_TO_ABI['18'];
} else if (NODE.startsWith('20')) {
NODE = NODE_TO_ABI['20'];
} else if (NODE.startsWith('22')) {
NODE = NODE_TO_ABI['22'];
} else {
ARGV_ERRORS.push(
'❌ Sentry: Invalid node version passed as argument, please make sure --target_node is a valid major node version. Supported versions are 16, 18 and 20.',
`❌ Sentry: Invalid node version passed as argument, please make sure --target_node is a valid major node version. Supported versions are ${Object.keys(
NODE_TO_ABI,
).join(', ')}.`,
);
}
}
Expand Down
Loading