Skip to content

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Nov 27, 2024

Resolves #14507

autoInstrumentRemix will be removed in v9 in favor of a coherent unified instrumentation experience OOTB.

@mydea
Copy link
Member

mydea commented Nov 27, 2024

IMHO we should not deprecate it, as setting this to true will be the default? So we do not want people to unset it, we actually want everyone to set it to true, I guess?

@lforst lforst changed the title feat(remix): Deprecate autoInstrumentRemix feat(remix): Deprecate autoInstrumentRemix: false Nov 27, 2024
@lforst
Copy link
Contributor Author

lforst commented Nov 27, 2024

IMHO we should not deprecate it, as setting this to true will be the default? So we do not want people to unset it, we actually want everyone to set it to true, I guess?

This PR technically only deprecates setting it to false. This is the best we can currently do I think.

@lforst
Copy link
Contributor Author

lforst commented Nov 27, 2024

I guess we should recommend setting this option to true in case it is currently set to false.

@lforst lforst merged commit a11630e into develop Nov 27, 2024
152 checks passed
@lforst lforst deleted the lforst-depr-air branch November 27, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate autoInstrumentRemix: false

4 participants