Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Nov 27, 2024

We do not align with how OTEL traces and the default samplers handle invalid span contexts today.
If a span context is invalid, e.g. the span ID or trace ID are invalid, then the span is ignored for new spans as a parent, and the new span will start a new trace. This change aligns our own sampling strategy with this, to ensure that invalid parent span contexts are ignored.

@mydea mydea self-assigned this Nov 27, 2024
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.14 KB - -
@sentry/browser - with treeshaking flags 21.86 KB - -
@sentry/browser (incl. Tracing) 35.55 KB - -
@sentry/browser (incl. Tracing, Replay) 72.46 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.84 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.78 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.23 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.75 KB - -
@sentry/browser (incl. FeedbackAsync) 32.55 KB - -
@sentry/react 25.81 KB - -
@sentry/react (incl. Tracing) 38.39 KB - -
@sentry/vue 27.29 KB - -
@sentry/vue (incl. Tracing) 37.35 KB - -
@sentry/svelte 23.29 KB - -
CDN Bundle 24.33 KB - -
CDN Bundle (incl. Tracing) 37.21 KB - -
CDN Bundle (incl. Tracing, Replay) 72.09 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.42 KB - -
CDN Bundle - uncompressed 71.45 KB - -
CDN Bundle (incl. Tracing) - uncompressed 110.51 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 223.58 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 236.79 KB - -
@sentry/nextjs (client) 38.72 KB - -
@sentry/sveltekit (client) 36.08 KB - -
@sentry/node 135.09 KB +0.02% +22 B 🔺
@sentry/node - without tracing 96.93 KB +0.02% +17 B 🔺
@sentry/aws-serverless 107.14 KB +0.03% +27 B 🔺

View base workflow run

@mydea mydea requested review from AbhiPrasad and Lms24 November 28, 2024 07:41
@mydea mydea marked this pull request as ready for review November 28, 2024 07:41
@mydea mydea merged commit e21c3bc into develop Nov 29, 2024
117 checks passed
@mydea mydea deleted the fn/sampler-ignore-invalid branch November 29, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants