fix(nextjs): Don't show warning about devtool option #14552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Dec 3, 2024
Co-authored-by: Francesco Novy <[email protected]>
AbhiPrasad
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrongfully assumend the devtool option would default to
undefinedbecause I missed this line in the Next.js code https://github.com/lforst/nextjs-fork/blob/36b0ff5074c441c55a862c14f0b6a45f0e789981/packages/next/src/build/webpack/config/blocks/base.ts#L61 and also stupidly had the devtool option set in my test app.This PR makes it so we don't unnecessarily show the warning if people have not disabled source maps.